Fix change length bug #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… last resort. Fix bug in CNV coordinate and change length calculation.
|
There is something wrong with Uniprot REST vs. Github runners. The tests run just fine on my machine. |
|
Sometimes Uniprot gets overloaded, which is what looks like happened when your checks ran. I usually give it some time and it works again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #93
The PR fixes a bug in change length calculation, removes trimming of the end coordinate before sending out to VEP for annotation, and prettifies the
GenomicInterpretationJSON snippets.Moreover, a documentation section regarding tests is added. From now on, we have 2 kinds of test, online and offline. The online tests must be marked by
@pytest.mark.onlineto not run them in standard CI due to spurious failures. In the long run, we should remove the online tests altogether and use mocks instead. The offline tests are just the regular tests.