Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish extending transcript exon model #70

Merged
merged 12 commits into from
Oct 3, 2023

Conversation

ielis
Copy link
Member

@ielis ielis commented Oct 2, 2023

Finish work on the model.

The main changes include:

  • Variant has coordinates, functional annotations, and genotypes.
  • use Genotype in the predicates. This is just a refactor, we must still finalize the predicate logic later
  • update toy data and set genotypes for the variant @lnrekerle please notice the lines 49 and 54 in the doctest output of tutorial.rst. I think we had a bug here where we would count the same variant with different genotypes twice (e.g. c.123C>T with homalt and het genotypes would be counted as 2 distinct variants despite being just one variant.).
  • update signature of FunctionalAnnotator to return a typing.Sequence[TranscriptAnnotation] instead of Variant
  • setup VariantTranscriptProteinArtist stub

@ielis ielis requested a review from lnrekerle October 2, 2023 18:18
Copy link
Collaborator

@lnrekerle lnrekerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Let me know if you change the variant_string function in here, or I can in my next PR.

@lnrekerle
Copy link
Collaborator

  • update toy data and set genotypes for the variant @lnrekerle please notice the lines 49 and 54 in the doctest output of tutorial.rst. I think we had a bug here where we would count the same variant with different genotypes twice (e.g. c.123C>T with homalt and het genotypes would be counted as 2 distinct variants despite being just one variant.).

Just noticed this comment. I can take a look at that after this is merged.

@ielis ielis merged commit a51d810 into develop Oct 3, 2023
@ielis ielis deleted the finish-extending-transcript-exon-model branch October 3, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants