Devries score update #352
Merged
Devries score update #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ielis
requested changes
Nov 14, 2024
There was a problem hiding this comment.
@pnrobinson looks good but let's first clarify my comment below.
src/gpsea/analysis/pscore/_hpo.py
Outdated
| for term_id in observed_term_ids: | ||
| for desc_tid in self._hpo.graph.get_ancestors(term_id, include_source=True): | ||
| if desc_tid.value == target_tid: | ||
| total_count += 1 | ||
| return total_count | ||
| return 1 |
There was a problem hiding this comment.
@pnrobinson
note that the methods _term_or_descendant_count (this) and _term_or_descendant (above) are now functionally identical.
Is that on purpose?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ielis
I updated the heuristic according to our discussion with Bert and Lex, and also updated the documentation. It should be ready to go.