Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.4.9 #1360

Merged
merged 49 commits into from
Jan 11, 2025
Merged

6.4.9 #1360

merged 49 commits into from
Jan 11, 2025

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Jan 4, 2025

  • Fix rare crashes on app startup
    MACOS_ONLY - Don't lock up app on close
  • Improve internal logging
  • Fixed background crash
  • Revert christmas/winter special
  • Fix crash on incoming non-spec-conformant LMC
  • Make xmpp gateway detection more robust (thanks lissine)
  • Add new action to directly block users on incoming subscription requests rather than just denying the request
  • Check if we are still joined when opening a channel/group and rejoin if not

tmolitor-stud-tu and others added 30 commits December 31, 2024 07:06
This reverts commit 72293f3.
While preapring for app freeze, we reset _shutdownPending to NO.
That deactivated the failsafe used to ignore idle states on disconnected
accounts and triggered a second shutdown.
(But since the app suspension was already triggered (the bg task was
terminated), the double shutdown got delayed to next app foreground.)
The second shutdown tried to flush the log, but the logging queue was
already suspended, so the flushing blocked the main thread indefinitely
leading to the iOS watchdog killing the app.

This was not visible in any logfiles, because of the suspended logging
queue, but our new udp logger force send made it visible.
This makes sure we get it even when killed by some watchdog while
disconnecting/shutting down
Before this commit, monal checked that an entity is not a gateway
by verifying that its identity's type is 'text'
https://xmpp.org/registrar/disco-categories.html#conference

But non-IRC gateways can have an identity type of 'text'.

Now, it will be checking that the entity does not advertise
a category of 'gateway', as that's more robust.
https://xmpp.org/extensions/xep-0100.html#example-3

This should work with Biboumi and Slidge.
This reverts commit 72293f3.
While preapring for app freeze, we reset _shutdownPending to NO.
That deactivated the failsafe used to ignore idle states on disconnected
accounts and triggered a second shutdown.
(But since the app suspension was already triggered (the bg task was
terminated), the double shutdown got delayed to next app foreground.)
The second shutdown tried to flush the log, but the logging queue was
already suspended, so the flushing blocked the main thread indefinitely
leading to the iOS watchdog killing the app.

This was not visible in any logfiles, because of the suspended logging
queue, but our new udp logger force send made it visible.
This makes sure we get it even when killed by some watchdog while
disconnecting/shutting down
tmolitor-stud-tu and others added 9 commits January 4, 2025 15:49
Before this commit, monal checked that an entity is not a gateway
by verifying that its identity's type is 'text'
https://xmpp.org/registrar/disco-categories.html#conference

But non-IRC gateways can have an identity type of 'text'.

Now, it will be checking that the entity does not advertise
a category of 'gateway', as that's more robust.
https://xmpp.org/extensions/xep-0100.html#example-3

This should work with Biboumi and Slidge.
- Revert christmas/winter special
- Fix crash on incoming non-spec-conformant LMC
- Make xmpp gateway detection more robust (thanks lissine)
- Add new action to directly block users on incoming subscription
requests rather than just denying the request
- Check if we are still joined when opening a channel/group and rejoin
if not
@tmolitor-stud-tu tmolitor-stud-tu merged commit 35b7a15 into stable Jan 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants