feat: misc minor QoL features #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meshiest
requested review from
voximity and
gluax
and removed request for
voximity
gluax
approved these changes
Apr 12, 2024
| pub static ref DEFAULT_AOT_BIN: PathBuf = | ||
| std::env::var("AOT_BIN").map(PathBuf::from).unwrap_or( | ||
| PathBuf::from(env!("CARGO_MANIFEST_DIR")).join("../../target/release/snarkos-aot"), | ||
| ); | ||
| pub static ref DEFAULT_AGENT_BIN: PathBuf = | ||
| std::env::var("AGENT_BIN").map(PathBuf::from).unwrap_or( | ||
| PathBuf::from(env!("CARGO_MANIFEST_DIR")).join("../../target/release/snops-agent"), |
There was a problem hiding this comment.
if we want the smaller binary. The path is different. I have the makefile outputting in in target/snops-agent-compressed. Or if you don't want to upx it, it would be in target/x86_64-unknown-linux-gnu/release-small/snarkos-aot
There was a problem hiding this comment.
this is kind of a workaround at the moment, we probably should just require the control plane to launch with a path to the agent as an arg
| @@ -192,10 +193,15 @@ impl From<FilenameString> for String { | |||
| } | |||
|
|
|||
| lazy_static! { | |||
| // TODO: support multiple architectures | |||
| pub static ref DEFAULT_AOT_BIN: PathBuf = | |||
| std::env::var("AOT_BIN").map(PathBuf::from).unwrap_or( | |||
| PathBuf::from(env!("CARGO_MANIFEST_DIR")).join("../../target/release/snarkos-aot"), | |||
voximity
reviewed
Apr 12, 2024
voximity
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connectin the storage work without requiring extra non-existent files./scripts/agent.sh(and prepare for dynamic endpoint ids)