Nx CI #771
Merged
Nx CI #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsa96
force-pushed
the
feat/ci
branch
3 times, most recently
from
641fa2e
to
104890d
Compare
We've tracked that there's something wrong with our bundling, we'll get to that. For now I just want CI to pass!
Was very messy and no real advantage to running this way. If needed we could add back if we can come up with a cleaner way of handling the env vars
tsa96
force-pushed
the
feat/ci
branch
2 times, most recently
from
185212b
to
4986f87
Compare
YAML formatter takes complete control over linebreaks in multiline strings, which makes scripts in Docker Compose files a nightmare to read. We barely use YAML anyway, may as well just disable.
Gocnak
reviewed
Jun 29, 2023
Gocnak
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds CI jobs for pull requests. Makes use of the glorious free runners from Github and runs the three biggest ones in separate jobs, really happy with the speed so far.
The frontend-e2e one isn't particularly useful yet, we literally only have one test, however it does verify that the site loads in a real browser without errors. And we'll hopefully be adding lots more frontend e2e testing in the future.