Fix Prisma transaction timeout during map submission #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a case of me keeping a Prisma transaction open for the lifetime of several S3 requests. I've pulled out the S3 logic to run in a separate task that won't block the DB work. Haven't written tests for this since I can't think of a reliable way to E2E test this and we'll test it out on staging tonight.
Panzerhandschuh
approved these changes
Sep 21, 2024
GordiNoki
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a case of me keeping a Prisma transaction open for the lifetime of several S3 requests. I've pulled out the S3 logic to run in a separate task that won't block the DB work.
Haven't written tests for this since I can't think of a reliable way to E2E test this and we'll test it out on staging tonight.
Closes #998
Checks
nx run db:create-migration <name>and committed the migration if I've made DB schema changesfeat: Add foo,chore: Update bar, etc...fixuped into my original commits