Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comparisons to settings #111

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Conversation

Natanxp2
Copy link
Contributor

@Natanxp2 Natanxp2 commented Jan 8, 2024

Adds mom_hud_comparisons_enable to settings under interface/hud

Checks

  • I have thoroughly tested all of the code I have modified/added/removed to ensure something else did not break
  • I have followed semantic commit messages e.g. feat: Add foo, chore: Update bar, etc...
  • My branch has a clear history of changes that can be easy to follow when being reviewed commit-by-commit
  • My branch is functionally complete; the only changes to be done will be those potentially requested in code review
  • All changes requested in review have been fixuped into my original commits.
  • Fully tokenized all my strings (no hardcoded English strings!!) and supplied bulk JSON strings below

POEditor JSON Strings (if needed)

[
	{
		"term": "Settings_ComparisonsHUD_Title",
		"definition": "Comparisons"
	}
	{
		"term": "Settings_ComparisonsHUD_Enable",
		"definition": "Display comparisons"
	}
	{
		"term": "Settings_ComparisonsHUD_Enable_Info",
		"definition": "Show comparisons on the HUD upon completion of a stage/checkpoint"
	}
]

@Natanxp2 Natanxp2 changed the title chore: add comparisons to settings Add comparisons to settings Jan 8, 2024
Copy link
Member

@tsa96 tsa96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've imported to POEditor.

@tsa96 tsa96 merged commit 0fa4fd2 into momentum-mod:master Jan 8, 2024
1 check passed
@Natanxp2 Natanxp2 deleted the add_settings branch January 8, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants