Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove constructor doc comments #33

Merged
merged 6 commits into from
Mar 26, 2024
Merged

fix: remove constructor doc comments #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2499093
fix: remove contructor doc comments
rishtigupta Mar 26, 2024
3750746
fix: add doc comments in form accepted by drupal.org
rishtigupta Mar 26, 2024
0812356
fix: add class namespace to constructor comment
rishtigupta Mar 26, 2024
a0dadad
fix: add class namespace to constructor comment
rishtigupta Mar 26, 2024
2cdbc23
fix: function and method declarations on a single line
rishtigupta Mar 26, 2024
2e234e0
fix: update MomentoCacheBackendFactory.php
rishtigupta Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Client/MomentoClientFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ class MomentoClientFactory {
private $logFile;

/**
* MomentoClientFactory constructor.
* Constructs a new \Drupal\momento_cache\Client\MomentoClientFactory object.
*/
public function __construct() {
$settings = Settings::get('momento_cache', []);
Expand Down
8 changes: 2 additions & 6 deletions src/MomentoCacheBackend.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,13 +79,9 @@ class MomentoCacheBackend implements CacheBackendInterface {
private $logFile;

/**
* MomentoCacheBackend constructor.
* Constructs a new Drupal\momento_cache\MomentoCacheBackend object.
*/
public function __construct(
$bin,
$client,
CacheTagsChecksumInterface $checksum_provider
) {
public function __construct($bin, $client, CacheTagsChecksumInterface $checksum_provider) {
$this->maxTtl = intdiv(PHP_INT_MAX, 1000);
$this->client = $client;
$this->bin = $bin;
Expand Down
10 changes: 3 additions & 7 deletions src/MomentoCacheBackendFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,18 +48,14 @@ class MomentoCacheBackendFactory implements CacheFactoryInterface {
private $backends = [];

/**
* MomentoCacheBackendFactory constructor.
* Constructs a new \Drupal\momento_cache\MomentoCacheBackendFactory object.
*/
public function __construct(
MomentoClientFactory $momento_factory,
CacheTagsChecksumInterface $checksum_provider
) {
public function __construct(MomentoClientFactory $momento_factory, CacheTagsChecksumInterface $checksum_provider) {
$this->momentoFactory = $momento_factory;
$this->checksumProvider = $checksum_provider;
$this->client = $this->momentoFactory->get();
$settings = Settings::get('momento_cache', []);
static::$cacheName = array_key_exists('cache_name', $settings) ?
$settings['cache_name'] : getenv("MOMENTO_CACHE_NAME");
static::$cacheName = array_key_exists('cache_name', $settings) ? $settings['cache_name'] : getenv("MOMENTO_CACHE_NAME");
}

/**
Expand Down
Loading