Skip to content

Commit

Permalink
chore: test matrix of PHP versions
Browse files Browse the repository at this point in the history
  • Loading branch information
pgautier404 committed Oct 13, 2023
1 parent aa073b3 commit 4cc5769
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
5 changes: 4 additions & 1 deletion .github/workflows/on-pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,10 @@ jobs:
test:
runs-on: ubuntu-latest
strategy:
max-parallel: 1
fail-fast: true
matrix:
php-version: ['7.4'] # , '8.0', '8.1']
php-version: ['7.4', '8.0', '8.1']

services:
mariadb:
Expand Down Expand Up @@ -164,3 +165,5 @@ jobs:
run: |
vendor/bin/phpunit --bootstrap $DRUPAL_ROOT/core/tests/bootstrap.php \
-c $MODULE_FOLDER/phpunit.xml $MODULE_FOLDER
env:
MOMENTO_CACHE_NAME_PREFIX: drupal-test-${{ matrix.php-version }}
4 changes: 2 additions & 2 deletions src/MomentoCacheBackendFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ public function __construct(
$this->momentoFactory = $momento_factory;
$this->checksumProvider = $checksum_provider;
$settings = Settings::get('momento_cache', []);
$this->cacheNamePrefix =
array_key_exists('cache_name_prefix', $settings) ? $settings['cache_name_prefix'] : "drupal-";
$this->cacheNamePrefix = array_key_exists('cache_name_prefix', $settings) ?
$settings['cache_name_prefix'] : "drupal-";
$this->client = $this->momentoFactory->get();
}

Expand Down

0 comments on commit 4cc5769

Please sign in to comment.