Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: showcase publisher_id in topics example #418

Merged
merged 4 commits into from
Jan 8, 2025
Merged

chore: showcase publisher_id in topics example #418

merged 4 commits into from
Jan 8, 2025

Conversation

anitarua
Copy link
Contributor

@anitarua anitarua commented Dec 18, 2024 •
edited
Loading

Closes https://github.com/momentohq/dev-eco-issue-tracker/issues/951

Now that generate_disposable_token is implemented, I updated this example to include that as well.

@anitarua anitarua marked this pull request as ready for review December 18, 2024 22:00
@anitarua anitarua requested a review from a team December 18, 2024 22:00
@anitarua anitarua mentioned this pull request Dec 18, 2024
Merged
@anitarua anitarua marked this pull request as draft January 3, 2025 18:43
@anitarua anitarua removed the request for review from a team January 3, 2025 18:43
@anitarua anitarua marked this pull request as ready for review January 3, 2025 21:15
@anitarua anitarua requested a review from a team January 3, 2025 21:16
malandis
malandis reviewed Jan 7, 2025
View reviewed changes
Copy link
Contributor

@malandis malandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example 2 could use some rework but looks good otherwise.

example/rust/src/bin/topics.rs Outdated Show resolved Hide resolved
example/rust/src/bin/topics.rs Show resolved Hide resolved
@anitarua anitarua requested review from malandis and a team January 8, 2025 00:05
@anitarua anitarua merged commit 0f06884 into main Jan 8, 2025
4 checks passed
@anitarua anitarua deleted the publisher-id-topics-example branch January 8, 2025 23:16
Merged
@anitarua anitarua mentioned this pull request Jan 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgautier404 pgautier404 pgautier404 approved these changes

@malandis malandis Awaiting requested review from malandis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anitarua @malandis @pgautier404