feat: add sorted-set examples #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malandis
reviewed
Oct 24, 2024
examples/composer.json
Outdated
| @@ -1,6 +1,7 @@ | |||
| { | |||
| "require": { | |||
| "momentohq/client-sdk-php": "1.11.1", | |||
| "momentohq/client-sdk-php": "dev-main", | |||
There was a problem hiding this comment.
🎗️ to revert this change once the new SDK is released
rishtigupta
force-pushed
the
feat/missing-examples
branch
from
24068ad to
0ad6e75
Compare
nand4011
reviewed
Oct 25, 2024
|
|
||
| // fetch sorted set by rank (0 to -1 for all elements) in ascending order | ||
| $logger->info("Fetching sorted set $SET_NAME\n"); | ||
| $response = $client->sortedSetFetchByRank($CACHE_NAME, $SET_NAME, 0, -1); |
There was a problem hiding this comment.
Why not leave off the ranks for fetching all elements?
There was a problem hiding this comment.
I am looking into that. It was giving me error saying:
[ex:]: Error fetching sorted set: Invalid argument passed to Momento client: minScore must be less than or equal to maxScore
nand4011
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description:
mainbranch ofclient-sdk-phprepo since we currently do not have a released sdk version that contains the sorted-set apisIssue
#213
https://github.com/momentohq/dev-eco-issue-tracker/issues/1033