chore: update list of retryable gRPC functions #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bring the list of retryable functions up to date. Replace GetHashCode with a version that matched the equals method. Fix misc warnings.
nand4011
commented
Dec 4, 2024
| @@ -37,35 +38,59 @@ public class DefaultRetryEligibilityStrategy : IRetryEligibilityStrategy | |||
| //StatusCode.DataLoss, | |||
| }; | |||
|
|
|||
| private readonly HashSet<Type> _retryableRequestTypes = new HashSet<Type> | |||
| private readonly HashSet<Type> _retryableRequestTypes = new() | |||
There was a problem hiding this comment.
Compare to the Go SDK version.
nand4011
commented
Dec 4, 2024
| } | ||
|
|
||
| public override int GetHashCode() | ||
| { | ||
| return base.GetHashCode(); |
There was a problem hiding this comment.
We have several classes that use base.GetHashCode(), which violates the contract that two objects that equal each other should have the same hash code. They are mostly unimportant like this one, but we should update them when we see them.
malandis
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring the list of retryable functions up to date.
Replace GetHashCode with a version that matched the equals method.
Fix misc warnings.