Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support topic sequence page #588

Merged
merged 4 commits into from
Nov 11, 2024
Merged

feat: support topic sequence page #588

merged 4 commits into from
Nov 11, 2024

Conversation

malandis
Copy link
Contributor

@malandis malandis commented Nov 8, 2024

Adds support for topic sequence page to the topic client.

Upgrades to latest protos and adds using statements for
`Momento.Protos.Common`.

The previous version of `Momento.Protos` we used here pre-dated where
we split several messages to `common.proto`. In order to isolate the
changes, we upgrade the dependency and add the missing `using`s here.`
Adds the topic sequence page to the topic subscribe workflow.
@malandis malandis changed the base branch from main to feat/upgrade-protos November 8, 2024 18:21
Base automatically changed from feat/upgrade-protos to main November 8, 2024 22:00
@malandis malandis marked this pull request as ready for review November 8, 2024 23:35
anitarua
anitarua previously approved these changes Nov 9, 2024
Copy link
Contributor

@anitarua anitarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm overall, just one docs nit

src/Momento.Sdk/ITopicClient.cs Outdated Show resolved Hide resolved
@malandis malandis merged commit 5d7b6d3 into main Nov 11, 2024
8 checks passed
@malandis malandis deleted the feat/topic-sequence-page branch November 11, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants