chore: refactor makefile and actions #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves readability
In an effort to make usage of the Makefile less error prone, we make the core targets (all, build, test) conditionally build against .NET Framework only when Windows is detected.
The GitHub actions run using grpc web and not using grpc web. We port this logic to the Makefile by adding a make variable `GRPC_WEB`.
anitarua
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the
Makefilein the following ways:buildandtestto be OS-conditional. When we detect Windows, we build and test against not just .NET 6.0 but also .NET Framework, the latter of which is Windows-only. This way a developer or consumer of theMakefiledoes not need to specify an OS-specific target (test-dotnet-frameworkvstest-dotnet-6)GRPC_WEBvariable. To build with gRPC web, runmake GRPC_WEB=true build.buildbuilds both .NET 6.0 and .NET Framework 4.62 targets; the same goes for when testing.PHONYdeclarations to the top for readability.