Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add MVI control methods #505

Merged
merged 3 commits into from
Oct 30, 2023
Merged

feat: add MVI control methods #505

merged 3 commits into from
Oct 30, 2023

Conversation

nand4011
Copy link
Contributor

Create initial MVI client with the create, list, and delete control methods.

Create initial configuration objects for the vector index client.

Generify the names of the simplest trace logging methods.

Fix a casting bug in the auth and token configuration equals methods.

Create initial MVI client with the create, list, and delete control
methods.

Create initial configuration objects for the vector index client.

Generify the names of the simplest trace logging methods.

Fix a casting bug in the auth and token configuration equals methods.
@nand4011 nand4011 requested a review from malandis October 12, 2023 23:25
Copy link
Contributor

@malandis malandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor changes to make 👍

src/Momento.Sdk/Config/AuthConfiguration.cs Show resolved Hide resolved
src/Momento.Sdk/Config/VectorIndexConfigurations.cs Outdated Show resolved Hide resolved
src/Momento.Sdk/IPreviewVectorIndexClient.cs Outdated Show resolved Hide resolved
src/Momento.Sdk/PreviewVectorIndexClient.cs Show resolved Hide resolved
@nand4011 nand4011 merged commit a72bff7 into main Oct 30, 2023
7 checks passed
@nand4011 nand4011 deleted the initial-mvi branch October 30, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants