Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use techie offset for basic ISO format #1660

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

snowwwz
Copy link

@snowwwz snowwwz commented Oct 3, 2024

Description of the Bug

with format: 'basic' option, toISO and toISOTime is supposed to return techie offset (ex. +0900)

* @example DateTime.now().toISO({ format: 'basic' }) //=> '20170422T204705.335-0400'

but, it returns short offset (ex. +09:00) with : instead.

% node
Welcome to Node.js v22.3.0.
Type ".help" for more information.
> const { DateTime } = await import("luxon");
undefined
> DateTime.now().toISO({ format: 'basic' });
'20241003T231708.609+09:00'

Copy link

linux-foundation-easycla bot commented Oct 3, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@mceachen
Copy link

mceachen commented Oct 4, 2024

Why would you make this change? It breaks prior default behavior and will almost certainly cause downstream issues.

Technically, ISO8601 states that the colon is optional, the default ISO format includes the colon. See https://en.wikipedia.org/wiki/ISO_8601

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants