API v1 & major refactoring: Hono, file read optimizations, and upload streaming #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A mollermeth of sorts |
|
true! |
nbitzz
suggested changes
Oct 6, 2023
|
Genius! Mr. 2283 and Mr. Impersonator will never find out |
|
i think all that's left now is maybe a little bit of cleanup and implementing account recovery but aside from that it's done |
Jack5079
reviewed
Jun 25, 2024
| <body> | ||
| <h1>monofile password reset</h1> | ||
| <form> | ||
| <input name="password" type="password"> |
There was a problem hiding this comment.
Suggested change
| <input name="password" type="password"> | |
| <input name="password" type="password" autocomplete="new-password"> |
https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete#sect13
A new password. When creating a new account or changing passwords, this should be used for an "Enter your new password" or "Confirm new password" field, as opposed to a general "Enter your current password" field that might be present. This may be used by the browser both to avoid accidentally filling in an existing password and to offer assistance in creating a secure password.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#15
A better & more sensible API which is actually usable for developers