Code

Fulfill or betray promises#68

Code

Open

jandockx wants to merge 28 commits intomoll:mastermoll/js-must:masterfrom jandockx:fulfill_or_betray_promisesjandockx/js-must:fulfill_or_betray_promisesCopy head branch name to clipboard

+565

Commits

Commits on Aug 31, 2017

• add promise method

  jandockx

  committed
  c291a07

• add promise documentation

  jandockx

  committed
  f7bcc4e

• add unit test for promise - ok for failures, but fails for things that should pass - added an actual to error reporting

  jandockx

  committed
  a64f863

• promise is a function, not a property with a getter

  jandockx

  committed
  ece3d5c

• remove NOK warning - promise tests are green

  jandockx

  committed
  45d510e

• add nop helper function for fulfill and betray

  jandockx

  committed
  66c5ae7

• add fulfill method

  jandockx

  committed
  d3a71d1

• add fulfill documentation

  jandockx

  committed
  bb50814

• fulfill is a function, not a property with a getter

  jandockx

  committed
  9e14a5f

• add betray method

  jandockx

  committed
  592807a

• add betray documentation

  jandockx

  committed
  ef3fb0f

• betray is a function, not a property with a getter

  jandockx

  committed
  c06a334

• add new methods to TS definition

  Show description for 1cb2baf
  jandockx

  committed
  1cb2baf

• generalise failing promise tests

  jandockx

  committed
  8c61412

• fix mistake in promise_test

  jandockx

  committed
  b737286

• Copy Promise require from resolve test, and remove optionality of Promise tests

  jandockx

  committed
  3d8a5ea

• Refactor isPromise test out, and repeat a little code, to get a good stack trace for fulfill and betray

  jandockx

  committed
  e6fc085

• fix a bug: make sure result of resolve or reject is propagated also when there is no condition

  Show description for 46b67ff
  jandockx

  committed
  46b67ff

• Make clear that not is confusing in documentation (it is not being tested against either)

  jandockx

  committed
  ce39985

• Add GREEN tests for fulfill

  jandockx

  committed
  8711db1

• add unit tests for betray, with 1 particular annoying test still failing - changed implementation of betray to avoid exception cycle, and added actual to assert error

  jandockx

  committed
  524f87b

• cleanup (removing unused code) of fulfill test

  jandockx

  committed
  1be6601

• marked test that has issues

  jandockx

  committed
  03bb54c

• fixed broken test

  Show description for 43b4ede
  jandockx

  committed
  43b4ede

• deal with UnhandledPromiseRejectionWarning

  Show description for 0117313
  jandockx

  committed
  0117313

Commits on Dec 11, 2017

• add Node v8 (LTS) to supported Node versions ("node" is now v9)

  jandockx

  committed
  e753a56

• fix mocha timeout with node 0.10 - we now get clear failing tests

  Show description for a112127
  jandockx

  committed
  a112127

• fix the problem with Promise stringification in test in Node 0.10 by calling stringify in test, and compare literally

  Show description for c77e39c
  jandockx

  committed
  c77e39c