Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp(core): Modify the entry value of the default setting to undefined… #372

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

0x0a0d
Copy link
Contributor

@0x0a0d 0x0a0d commented Oct 25, 2023

Limitation in the mergeSchemaSettings function (service.js#L668), where the default moleculer-db setting's entry value was set to null, preventing it from being overridden by other mixins.

By changing the default entry value to undefined, it now aligns with Lodash’s defaultsDeep method, which prioritizes values that are not undefined

… that permit its overwrite from other mixins.
@icebob
Copy link
Member

icebob commented Nov 12, 2023

You can overwrite these values as well, just you should reorder the mixins

@0x0a0d
Copy link
Contributor Author

0x0a0d commented Nov 12, 2023

I think it is better to change null to undefined. You can bump the minor version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants