-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a watch on 'open' for dynamic open changes #41
base: master
Are you sure you want to change the base?
Conversation
For this a simple scope.$watch('open', function(value) { scope.isOpen = !!value; }); |
I only modified the src version, I was unclear if the dist version was generated as well as the minified versions. Let me know if there is more integration needed. |
I treated it as a singleton because I was not sure if the watch would be added on every link phase. If you'd prefer I could remove the singleton approach. |
The singleton won't help much here. |
- Changed open watch to no longer be a singleton
any update on this? Dynamic open attr would be fantastic |
My plan is to use json-formatter-js for internally in this directive (#35) . That will make this directive a thin wrapper around the core lib. If you have time to do it I'll help merging and releasing it. |
…eper) objects" This reverts commit f4c4927.
…ecial work needed - Added branch specific tests section to the demo.html to easily test the branch features
…tion to the decimal value
Any chance we can have the watched open attribute? Whats the status of this? |
This is a simple change to implement #34. I am a little green at some of this stuff so this may not be the best approach. I tested the changes with simple collapse all/none buttons and they seemed to work well--redrew the content when a button was pressed.