feat: enable file uploads on links and media #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit enable the "upload" button on "links" and "media" According to TinyMCE documentation for enable this functionality you must declare "file_picker_callback" function on tinyEditor initialization.
|
Could you let me know if you checked it carefully on your side? This package adopts v5 of the TinyEditor, and you mentioned a link for v6, but I believe it's the same in both. |
|
My apologies for the wrong reference. But it's the same rule on both versions. We use your package on many websites, and everytime the user needs to upload a file on a link we implement a CustomTinyEditor with the same code in this PR |
|
Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR enable the "upload" button on "links" and "media"
According to TinyMCE documentation for enable this functionality you must declare "file_picker_callback" function on tinyEditor initialization.
more info:
https://www.tiny.cloud/docs/tinymce/6/image/#file_picker_callback