-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] Remove sms from android store #1889 #1890
base: master
Are you sure you want to change the base?
[DRAFT] Remove sms from android store #1889 #1890
Conversation
applicationIdSuffix '.debug' | ||
debuggable true | ||
minifyEnabled false | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code adds a test version of same app with name DQKSMS so that I can test on phone along with prod still installed.
We can get rid of this if you feel its not required after testing
@@ -39,7 +39,7 @@ | |||
|
|||
<application | |||
android:name=".common.QKApplication" | |||
android:allowBackup="true" | |||
android:allowBackup="false" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one syncs the database/preferences to Google cloud which won't make sense in most of the app instances. We can remove this if you think otherwise.
<application | ||
android:allowBackup="false" | ||
android:icon="@mipmap/ic_launcher" | ||
android:label="DQKSMS" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is needed to give the name DQKSMS for debug app.
This is more like extends default manifest and has only overrides like app name.
Also removed sync from happening automatically when default messaging app changes
Addresses #1889
Used this app for a day and realized the following
Will update this as I face more things
Code snippet for problem 1