Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes for vanilla twig and import completions #59

Merged
merged 15 commits into from
Nov 20, 2024
Merged

fixes for vanilla twig and import completions #59

merged 15 commits into from
Nov 20, 2024

Conversation

Zekfad
Copy link
Contributor

@Zekfad Zekfad commented Nov 18, 2024 •
edited
Loading

I'm developing and testing this from Windows 10 machine.

  • Fixes completions and correctly replaces string content on completion accept.
  • Adds progressive filtering of completions (especially helpful with lots of templates).
  • Vanilla Twig support chain and filesystem loaders.
  • Vanilla Twig correctly format namespaces for LSP.
  • Update generated tree-sitter-twig.
  • Fix references search and navigation to template source.

@Zekfad
feat(lsp): correctly format namespaces and support chained loaders
35df369
@Zekfad
fix: use static names for custom commands
a725735 
this fixes thrown exception when custom command in used
since lsp registeres only static name and extension calls dynamic one
@Zekfad
fix: update tree-sitter-twig from nan to napi
505880a 
this also (partially) fixes clean builds
@Zekfad
fix: completions and ranges
0e79aef 
this fixes unstable completions and allows to correctly insert
completion inside of string node
@Zekfad
fix(build): use relative path for wasm module
de8755d 
this fixes build on win32
@Zekfad
refactor: add additional logging
1c56340
@Zekfad Zekfad mentioned this pull request Nov 18, 2024
Open
@Zekfad
feat: template diagnostic and defintion for block template argument
582356e 
also fixes incorrect reference from defintion of block with template argument
@Zekfad
Copy link
Contributor Author

Zekfad commented Nov 18, 2024

This should also fix #58 and #49
image
image
image

@Zekfad Zekfad marked this pull request as ready for review November 18, 2024 03:16
moetelo
moetelo requested changes Nov 18, 2024
View reviewed changes
Copy link
Owner

@moetelo moetelo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is terrific in the best way possible

(don't mind the number of comments)

packages/language-server/phpUtils/getTwigMetadata.php Outdated Show resolved Hide resolved
packages/language-server/phpUtils/getTwigMetadata.php Outdated Show resolved Hide resolved
packages/language-server/phpUtils/getTwigMetadata.php Outdated Show resolved Hide resolved
packages/tree-sitter-twig/package.json Show resolved Hide resolved
packages/vscode/build/index.mjs Outdated Show resolved Hide resolved
packages/language-server/src/diagnostics/DiagnosticProvider.ts Outdated Show resolved Hide resolved
packages/language-server/src/utils/node/isPathInsideTemplateEmbedding.ts Outdated Show resolved Hide resolved
packages/vscode/src/extension.ts Outdated Show resolved Hide resolved
packages/language-server/src/completions/template-paths.ts Outdated Show resolved Hide resolved
packages/language-server/src/completions/template-paths.ts Outdated Show resolved Hide resolved
moetelo
moetelo approved these changes Nov 20, 2024
View reviewed changes
Copy link
Owner

@moetelo moetelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@moetelo moetelo merged commit f3f6402 into moetelo:master Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moetelo moetelo moetelo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zekfad @moetelo