Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: v1.0.0 #34

Merged
merged 48 commits into from
Sep 15, 2024
Merged

feat: v1.0.0 #34

merged 48 commits into from
Sep 15, 2024

Conversation

gioboa
Copy link
Collaborator

@gioboa gioboa commented Aug 4, 2024

features:

  • based on Module Federation 2 via @module-federation/runtime library

zhangHongEn and others added 7 commits August 1, 2024 15:12
* fix: tsconfig

* fix: issues 2 3

* feat: rust demo build and preview

---------

Co-authored-by: 张洪恩 <[email protected]>
* fix: Ensure @module-federation/runtime singleton

* fix: build preview

---------

Co-authored-by: 张洪恩 <[email protected]>
README.md Show resolved Hide resolved
@gioboa
Copy link
Collaborator Author

gioboa commented Aug 5, 2024

We can test the package with this alpha version
1.0.0-alpha-7c3ba59

@gioboa gioboa changed the title v1.0.0 feat: v1.0.0 Aug 6, 2024
@husayt
Copy link
Contributor

husayt commented Aug 7, 2024

@gioboa can we enable discussions section in this repo and also to make it easy would be great if you could give some moderation rights so I could help with triaging issues

@husayt
Copy link
Contributor

husayt commented Aug 7, 2024

I made a simple repro to test this case. Will try to commit that later. But gist of it I added another remote with
with these dependencies

  "dependencies": {
    "@module-federation/vite": "workspace:*",
    "react": "^18.2.0",
    "react-dom": "^18.2.0",
    "vue": "^3.4.29",
    "vue-router": "^4.4.0",
    "ag-grid-community": "^30.2.0",
    "ag-grid-react": "^30.2.0"
  },

and AgGridDemo.jsx

import 'ag-grid-community/styles/ag-grid.css';
import 'ag-grid-community/styles/ag-theme-alpine.css';
import { AgGridReact } from 'ag-grid-react';
import { useState } from 'react';


export const AgGridDemo = ({  }) => {
  const [rowData] = useState([
    { make: 'Toyota', model: 'Celica', price: 35000 },
    { make: 'Ford', model: 'Mondeo', price: 32000 },
    { make: 'Porsche', model: 'Boxter', price: 72000 },
  ]);

  const [columnDefs] = useState([{ field: 'make' }, { field: 'model' }, { field: 'price' }]);

  return (
    <div className="App">
      <div style={{ display: 'flex', flexDirection: 'row' }}>
        <div
          id="grid1"
          className="ag-theme-alpine"
          style={{ height: 400, width: 600, margin: '20px' }}
        >
          <AgGridReact rowData={rowData} columnDefs={columnDefs}></AgGridReact>
        </div>
        <div
          id="grid2"
          className="ag-theme-alpine"
          style={{ height: 400, width: 600, margin: '20px' }}
        >
          <AgGridReact rowData={rowData} columnDefs={columnDefs}></AgGridReact>
        </div>
      </div>
    </div>
  );
};

When running this remote on its own all works fine.

But when I try to run it from another host via MF I get the same error

Object.useRef (chunk-D5PPDA7K.js:1074:29)
    at AgGridReactUi (ag-grid-react.js:69725:36)
    at renderWithHooks (chunk-BISVECJP.js:11548:26)
    at mountIndeterminateComponent (chunk-BISVECJP.js:14926:21)
    at beginWork (chunk-BISVECJP.js:15914:22)
    at HTMLUnknownElement.callCallback2 (chunk-BISVECJP.js:3674:22)
    at Object.invokeGuardedCallbackDev (chunk-BISVECJP.js:3699:24)
    at invokeGuardedCallback (chunk-BISVECJP.js:3733:39)
    at beginWork$1 (chunk-BISVECJP.js:19765:15)
    at performUnitOfWork (chunk-BISVECJP.js:19198:20)

zhangHongEn and others added 7 commits August 10, 2024 15:30
* fix: pre-bunding

* feat: add pre-bunding subdependencies demo

* fix: exposes .

* fix: remotes support namespace
husayt and others added 7 commits August 16, 2024 20:57
Co-authored-by: 张洪恩 <[email protected]>
* feat: shared slash

* feat: shared slash

* feat: preview examples

* feat: remove an-empty-js-file

* fix: remove console

* optimization: reduce dev mode page reload

* Optimize code and comments

* fix: 64

* fix: only slash

---------

Co-authored-by: 张洪恩 <[email protected]>
@nicotu01
Copy link

I'm excited to see this version 1.0.0 released. Thank you for this initiative.
Is the current version sufficiently mature to be tested?

@zhangHongEn
Copy link
Contributor

About 10 issues have been resolved in the past month, and there is only one bug #68 left which will be fixed soon
You can try, new-config branch
pnpm install && pnpm run dev && pnpm run dev-vv

@gioboa
Copy link
Collaborator Author

gioboa commented Aug 30, 2024

We are building a new alpha release after every fix too. You can use that if you want

https://www.npmjs.com/package/@module-federation/vite/v/1.0.0-alpha-661e052?activeTab=versions

Screenshot_20240830-124003.jpg

zhangHongEn and others added 14 commits August 31, 2024 14:41
* fix: #68

* fix: #68

* fix: windows Multi-Pack

* Optimization: Reduce file writing

* Optimization: code format

* fix: support nx monorepo

---------

Co-authored-by: 张洪恩 <[email protected]>
Co-authored-by: 张洪恩 <[email protected]>
* Add Nuxt host example

* Gitignore generated .__mf__win folder

---------

Co-authored-by: David Sellén <[email protected]>
Co-authored-by: David Sellén <[email protected]>
* fix: #78

* Update src/utils/normalizeOptimizeDeps.ts

Co-authored-by: Sergey Melyukov <[email protected]>

---------

Co-authored-by: 张洪恩 <[email protected]>
Co-authored-by: Sergey Melyukov <[email protected]>
* fix: Remote virtual module path

* examples: nuxt(Unfinished)

* feat: mf-manifest; Register remote on demand

* doc: roadmap

* doc: npm url

* Delete src/utils/getLocalSharedImportMap_windows.ts

---------

Co-authored-by: 张洪恩 <[email protected]>
@gioboa
Copy link
Collaborator Author

gioboa commented Sep 15, 2024

This implementation is so great and it's working fine. I'll merge this PR inside main.

@gioboa gioboa merged commit b1bba84 into main Sep 15, 2024
1 check passed
@gioboa gioboa deleted the new-config branch September 15, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants