Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add types for dev and dts properties #118

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

IrishBruse
Copy link
Contributor

@IrishBruse IrishBruse commented Sep 28, 2024

Add types for dev and dts

@IrishBruse IrishBruse changed the title Add types Add types for dev and dts properties Sep 28, 2024
@gioboa gioboa changed the title Add types for dev and dts properties chore: add types for dev and dts properties Sep 28, 2024
Copy link
Collaborator

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help @IrishBruse
It looks great to me

@gioboa gioboa merged commit f84b83f into module-federation:main Sep 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants