fix: Fix the problem that the previous demo cannot run properly (#3280)

module-federation · Oct 27, 2023 · f65d4a5 · f65d4a5 · vercel · Oct 27, 2023
1 parent d8add5d
commit f65d4a5
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/federated-npm/app1/src/App.js b/federated-npm/app1/src/App.js
@@ -1,5 +1,5 @@
 import React from 'react';
-import('app1')
+import('app3')
 const RemoteButton = React.lazy(() => import('app2/Button'));
 import lodash from 'lodash';
 import merge from 'lodash.merge';

diff --git a/federated-npm/app1/webpack.config.js b/federated-npm/app1/webpack.config.js
@@ -8,7 +8,7 @@ const remotes = {
 }
 
 const delegatedRemote = {
-  app3: "app1@http://localhost:3003/remoteEntry.js",
+  app3: "app3@http://localhost:3003/remoteEntry.js",
 }
 
 const delegatedRemotesObject = Object.entries(delegatedRemote).reduce((acc, [name, url]) => {

diff --git a/federated-npm/package.json b/federated-npm/package.json
@@ -17,6 +17,7 @@
     "e2e:ci": "yarn start & wait-on http-get://localhost:3001/ && npx cypress run --config-file ../cypress/config/cypress.config.ts --config '{\"supportFile\": \"../cypress/support/e2e.ts\"}' --spec \"./e2e/*.cy.ts\" --browser=chrome"
   },
   "devDependencies": {
-    "lerna": "3.22.1"
+    "lerna": "3.22.1",
+    "wait-on": "7.0.1"
   }
 }
diff --git a/loadable-react-16/package.json b/loadable-react-16/package.json
@@ -14,6 +14,7 @@
     "e2e:ci": "yarn start & wait-on http-get://localhost:3000/ && npx cypress run --config-file ../cypress/config/cypress.config.ts --config '{\"supportFile\": \"../cypress/support/e2e.ts\"}' --spec \"./e2e/*.cy.ts\" --browser=chrome"
   },
   "devDependencies": {
-    "lerna": "3.22.1"
+    "lerna": "3.22.1",
+    "wait-on": "7.0.1"
   }
 }