Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse lists of e-mail recipients properly #145

Merged
merged 1 commit into from Jan 25, 2018
Merged

parse lists of e-mail recipients properly #145

merged 1 commit into from Jan 25, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jan 25, 2018

A comma (,) is a valid separator in accordance with RFC 2822, it was Microsoft Outlook that introduced the use of semicolon (;).

getaddresses() will correctly split a string containing multiple e-mail addresses separated by a comma or semicolon.

closes #121

A comma (,) is a valid separator in accordance with RFC 2822, it was Microsoft Outlook that introduced the use of semicolon (;).

getaddresses() will correctly split a string containing multiple e-mail addresses separated by a comma or semicolon.

closes #121
@ghost ghost added the bug label Jan 25, 2018
@ghost ghost self-assigned this Jan 25, 2018
@ghost ghost mentioned this pull request Jan 25, 2018
1 task
@ghost
Copy link
Author

ghost commented Jan 25, 2018

Builds fail because of 19d21cc (#144)

@tonioo tonioo added this to the 1.4.0 milestone Jan 25, 2018
@tonioo tonioo closed this Jan 25, 2018
@tonioo tonioo reopened this Jan 25, 2018
@codecov
Copy link

codecov bot commented Jan 25, 2018

Codecov Report

Merging #145 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
- Coverage   74.32%   74.28%   -0.04%     
==========================================
  Files          23       23              
  Lines        2029     2034       +5     
==========================================
+ Hits         1508     1511       +3     
- Misses        521      523       +2
Impacted Files Coverage Δ
modoboa_webmail/validators.py 100% <100%> (ø) ⬆️
modoboa_webmail/__init__.py 75% <0%> (-25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6217463...63d69be. Read the comment docs.

@tonioo tonioo merged commit c4c5377 into modoboa:master Jan 25, 2018
@ghost ghost deleted the fix/issue-121 branch January 25, 2018 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reply to Mail sends to wrong recipient
2 participants