Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make passwd for postgres too #311

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

ionescu77
Copy link
Contributor

@ionescu77 ionescu77 commented Apr 17, 2020

Description of the issue/feature this PR addresses:

Modoboa-installer installation on Centos 7.6, with Postgresql would fail.
This would happen if the user does not specify password and goes on with default setting.

see Issue #296

Current behavior before PR:

Actually the clamav and other modules dependant on the DB would fail starting.

Desired behavior after PR is merged:

After I modified the postgres entry to look like mysql (make_password, instead of empty default), I was able to complete the install script and have all services running.

@codecov
Copy link

codecov bot commented Apr 17, 2020

Codecov Report

Base: 50.07% // Head: 50.07% // No change to project coverage 👍

Coverage data is based on head (bcb754c) compared to base (06a81c7).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #311   +/-   ##
=======================================
  Coverage   50.07%   50.07%           
=======================================
  Files          10       10           
  Lines         681      681           
=======================================
  Hits          341      341           
  Misses        340      340           
Impacted Files Coverage Δ
modoboa_installer/config_dict_template.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ionescu77
Copy link
Contributor Author

ionescu77 commented Apr 17, 2020

I first tried to address this in PR #304 , however my fork was out of sync therefore too many differences would show up in Files Changed.
Now it is just this tinny modification.

@tonioo
Copy link
Member

tonioo commented Jun 2, 2020

@ionescu77 Thank you. Have you tried your modification on a Debian/Ubuntu system?

@ionescu77
Copy link
Contributor Author

ionescu77 commented Jun 2, 2020 via email

@ionescu77 ionescu77 changed the title Make passwd for postgres too see #296 Make passwd for postgres too Dec 6, 2020
@ksaadDE
Copy link
Contributor

ksaadDE commented Jun 27, 2022

Hello,

Bon soir. No debian/Ubuntu at hand. [...] I'm not sure I can experiment on ubuntu this weeks are a bit busy for me :-/ Best, Raz

Did u got less busy? Tests done?

Regards

@ionescu77
Copy link
Contributor Author

@ksaadDE Hello, man I am not using debian/ubuntu at work I have only centos and only an old Ubuntu 18.04.6 LTS running the network management software, and I'm reluctant to use it.

If somebody please has some Ubuntu lying around :(

If you look at the commit it's a one liner, basically the make_password function was never called. I did not do any modoboa deployment since then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants