fix: House lock downs and secure ownership bugs #940
Conversation
| @@ -2070,7 +2070,7 @@ private void SetLockdown(Item i, bool locked, bool checkContains = false) | |||
|
|
|||
| public bool LockDown(Mobile m, Item item, bool checkIsInside) | |||
| { | |||
| if (!IsCoOwner(m) || !IsActive) | |||
| if (!IsFriend(m) || !IsActive) | |||
There was a problem hiding this comment.
I am not sure if this is right. Let's do some testing.
There was a problem hiding this comment.
Friends of the house have always been allowed to lock things down. This was tested via OSI and is at the link: https://uo.com/wiki/ultima-online-wiki/gameplay/houses-placing-a-house/house-ownership-4-managing-your-home/
| @@ -2408,7 +2423,17 @@ public void AddSecure(Mobile m, Item item) | |||
| } | |||
| else | |||
| { | |||
| info = new SecureInfo((Container)item, SecureLevel.Owner); | |||
| /* There seems to be some confusion regarding security access on secured containers. | |||
There was a problem hiding this comment.
The owner of the house should have access to everything.
This is both necessary and a problem since owners can hijack co-owner/friend property.
I am not sure this can be resolved.
There was a problem hiding this comment.
I agree. House owners should automatically have access to everything. Perhaps we can make a new securelevel.HouseOwner and Co-Owners can become securelevel.Owners?
There was a problem hiding this comment.
Maybe we need to separate the security access levels and the house access levels. These are obviously not interchangeable. The security access levels only apply to each individual container in question and are applicable to the individual who secured said container, NOT the house owner (although they have access/control over it regardless).
For things like doors and teleporters, the house owner is automatically the owner.
|
|
|
It feels like the first item on the list is a bug. I agree that this should be fixed if that is the case. The default security level should be the highest for that person's current access. If they are a friend, it is friend. If they are a co-owner, it is co-owner, etc. The second one is also clearly a bug. Let's move forward with this. I'll find some time to look into this more and clean up this PR. |
kamronbatman
changed the title
Currently reworking house lockdowns/Secures. This closely resemble OSI but still needs fixes before release.