-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor/restyle HouseGump
and supporting gumps
#1925
Draft
IcculusC
wants to merge
10
commits into
main
Choose a base branch
from
feat-refactor-house-gumps
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana for .NET3 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Detected 18 dependenciesThird-party software listThis page lists the third-party software dependencies used in ModernUO
Contact Qodana teamContact us at [email protected]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I've consolidated the
HouseListGump
andHouseRemoveGump
into a newly-refactored, multi-pageHouseGump
.Additionally, I added some imagery and rearranged some of the options.
I did this mostly as an exercise in creating complex gumps, but it's also a bit of an upgrade.
The real question is whether or not the "paged" gump is a good thing. I've effectively built this such that it wouldn't be prohibitively difficult to break each page into it's own gump.I have since refactored to use a "sectional" gump. Each section (Info
,Friends
, andOptions
) is rendered as the first page in the gump, and the paging behavior for house sign selection and people management are encompassed by section. This means the entire gump is no longer one giant paged gump, and prevents building the layout for the people lists when a user is only viewing the info section (for example).Sections
There are many pages and variations, so I have only included the significant stylistic changes here.
homepage
private house options
public house options
sign selection