Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docker configuration #1481

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

thecatontheflat
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Aug 31, 2023

CLA assistant check
All committers have signed the CLA.

@thecatontheflat
Copy link
Contributor Author

image

@kamronbatman perhaps you could point me in the right direction before I start digging.

In the screenshot above, it shows 100% time out. However, it managed to connect.
Do you know if the game server requires more ports open than just the default 2593?

@thecatontheflat
Copy link
Contributor Author

Not much in the server logs. Just acknowledging a client was connected, and then disconnected (once I selected the shard in the game client):

image

@kamronbatman
Copy link
Contributor

No it doesn't. I have never seen that. I would need to dig through the code too in order to find out.

@thecatontheflat
Copy link
Contributor Author

https://github.com/ServUO/ServUO/pull/5047/files

They had a similar issue. Will port the fix here too

@thecatontheflat thecatontheflat deleted the branch modernuo:main September 5, 2023 09:44
@kamronbatman
Copy link
Contributor

@thecatontheflat - Why was this closed? I was hoping to merge it!

@thecatontheflat
Copy link
Contributor Author

Essentially, to make it a smooth developer experience and to containerize it properly, these things need to be addressed:

  • Server IP binding when connecting from the host machine (can be either solved via proposed change to the ServerList, or by offloading this configuration to the developer and let them figure it out with Docker (or Docker Compose) networks.
  • Exposing server configuration via mount or via environmental variables. Currently, to change server configuration, it needs to be changed within the container.
  • For an easier development process, the project files can be mounted from the host via volume binds, in which case it requires mapping user from host to container

It felt like it started bringing more issues than fixes, so I didn't want to steal anyone's attention.

Thoughts?

@kamronbatman
Copy link
Contributor

Can we address this by modifying docker-compose to include a network bridge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants