Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move defaults and types to constants #9

Merged
merged 6 commits into from
Jan 17, 2024
Merged

Move defaults and types to constants #9

merged 6 commits into from
Jan 17, 2024

Conversation

pan-x-c
Copy link
Collaborator

@pan-x-c pan-x-c commented Jan 16, 2024 •
edited
Loading

name: Move defaults and types into constants

Description

  1. Move default values and types into a single file and avoid duplication of definitions
  2. rename _Operator to Operator
  3. fix the typing issue in pipeline package
  4. optimize the order of parameters in functional pipeline
  5. update docstring and sphinx doc

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@pan-x-c pan-x-c added the enhancement New feature or request label Jan 16, 2024
@pan-x-c pan-x-c requested review from qbc2016 and DavdGao January 16, 2024 03:20
@pan-x-c pan-x-c self-assigned this Jan 16, 2024
@pan-x-c pan-x-c changed the title Move defaults and types to constants [WIP] Move defaults and types to constants Jan 16, 2024
@pan-x-c pan-x-c changed the title [WIP] Move defaults and types to constants Move defaults and types to constants Jan 16, 2024
DavdGao
DavdGao reviewed Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see inline comments

src/agentscope/constants.py Outdated Show resolved Hide resolved
src/agentscope/pipelines/functional.py Outdated Show resolved Hide resolved
src/agentscope/pipelines/functional.py Outdated Show resolved Hide resolved
src/agentscope/pipelines/functional.py Outdated Show resolved Hide resolved
src/agentscope/pipelines/functional.py Outdated Show resolved Hide resolved
src/agentscope/pipelines/functional.py Outdated Show resolved Hide resolved
src/agentscope/pipelines/functional.py Outdated Show resolved Hide resolved
qbc2016
qbc2016 approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@qbc2016 qbc2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pan-x-c pan-x-c merged commit 24a3cc0 into modelscope:main Jan 17, 2024
4 checks passed
rayrayraykk pushed a commit that referenced this pull request Feb 26, 2024
@ZiTao-Li
Merge pull request #9 from rayrayraykk/dev_foodlist
e0ba18c 
Add magic pot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavdGao DavdGao DavdGao left review comments

@qbc2016 qbc2016 qbc2016 approved these changes

Assignees

@pan-x-c pan-x-c

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pan-x-c @qbc2016 @DavdGao