Support callable model in agentbase #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…model # Conflicts: # docs/sphinx_doc/source/tutorial/203-model.md
…model # Conflicts: # README.md # README_ZH.md # src/agentscope/agents/dialog_agent.py # src/agentscope/agents/dict_dialog_agent.py # src/agentscope/agents/text_to_image_agent.py
ZiTao-Li
reviewed
Mar 21, 2024
| @@ -48,7 +49,8 @@ def __init__( | |||
| sys_prompt (`Optional[str]`): | |||
| The system prompt of the agent, which can be passed by args | |||
| or hard-coded in the agent. | |||
| model_config_name (`str`, defaults to None): | |||
| config_name_or_model (`[str, Callable[..., Any]`, defaults to | |||
| None): | |||
| The name of the model config, which is used to load model from | |||
There was a problem hiding this comment.
"name of the model config to load model from configuration, or a callable instance of model for inference"? Same for DialogAgent and other agents
| "use_memory": true | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| 在这个配置中，Player1被指定为一个DictDialogAgent。参数包括一个系统提示（sys_prompt），它可以指导agent的行为；一个模型配置名（model_config_name），它决定了模型配置的名称；以及一个标志（use_memory），指示agent是否应该记住过去的互动。 | ||
| 在这个配置中，Player1被指定为一个DictDialogAgent。参数包括一个系统提示（sys_prompt），它可以指导agent | ||
| 的行为；一个模型配置名（config_name_or_model），它决定了模型配置的名称；以及一个标志（use_memory），指示agent是否应该记住过去的互动。 |
myh-0521
pushed a commit
to myh-0521/agentscope
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Background
Since more and more model wrappers are added into AgentScope, maybe it's not a good idea to list "how to set model configs" for all wrappers in our README.md and tutorial.
Therefore, we should support to pass callable model into agent, enabling developers to skip setting model config, and just choose the model wrappers under
agentscope.models.By this way, we only need to add new wrapper class, together with its docstring, rather than updating README.md and tutorial for each time.
Note
This is an important change. Maybe we will move away from using model config, please check if it's appropriate.
Checklist
Please check the following items before code is ready to be reviewed.