-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notebook executor as service function and add codeact agent. #231
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please see inline comments
- Add README.md for the example.
- Add the new service class into the service section in tutorial
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see inline comments, other lgtm
examples/conversation_with_codeact_agent/codeact_agent_example_modeling.ipynb
Show resolved
Hide resolved
examples/conversation_with_codeact_agent/codeact_agent_example_modeling.ipynb
Show resolved
Hide resolved
examples/conversation_with_codeact_agent/codeact_agent_example_tools.ipynb
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, and we should keep on updating and optimizing this module
Besides, a unit test is required for this new service module, and add the new service class into the service section in tutorial
Description
Checklist
Please check the following items before code is ready to be reviewed.