Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOTFIX] Fix bug in the format method of ollama and litellm #230

Merged
merged 1 commit into from
May 17, 2024

Conversation

DavdGao
Copy link
Collaborator

@DavdGao DavdGao commented May 17, 2024

Description

As the title says, within the react agent, it will pass "...{index}. {function_name} ..." to format method as system prompt, which will occur error in the string's format method.

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@DavdGao DavdGao requested review from ZiTao-Li and garyzhang99 May 17, 2024 02:17
@DavdGao DavdGao linked an issue May 17, 2024 that may be closed by this pull request
Copy link
Collaborator

@garyzhang99 garyzhang99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garyzhang99
Copy link
Collaborator

Maybe we should enhance the format_test.py later, with a new PR.

@DavdGao DavdGao merged commit 1f22e67 into modelscope:main May 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]:最新版本运行ollma api报错如下
2 participants