Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ZhipuAI model wrappers #181

Merged
merged 25 commits into from
May 6, 2024
Merged

Add ZhipuAI model wrappers #181

merged 25 commits into from
May 6, 2024

Conversation

garyzhang99
Copy link
Collaborator

@garyzhang99 garyzhang99 commented Apr 26, 2024 •
edited
Loading

name: Add ZhipuAI model wrappers
about: Create a pull request

Description

Support ZhipuAI API in agentscope.

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@garyzhang99 garyzhang99 self-assigned this Apr 26, 2024
@garyzhang99 garyzhang99 added feature documentation Improvements or additions to documentation enhancement New feature or request and removed feature labels Apr 26, 2024
@garyzhang99 garyzhang99 requested review from DavdGao and pan-x-c April 26, 2024 07:12
ZiTao-Li
ZiTao-Li reviewed Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@ZiTao-Li ZiTao-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see inline comments

docs/sphinx_doc/zh_CN/source/tutorial/206-prompt.md Show resolved Hide resolved
src/agentscope/models/zhipu_model.py Outdated Show resolved Hide resolved
src/agentscope/models/zhipu_model.py Show resolved Hide resolved
DavdGao
DavdGao reviewed Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz see inline comments

docs/sphinx_doc/en/source/tutorial/203-model.md Outdated Show resolved Hide resolved
docs/sphinx_doc/zh_CN/source/tutorial/203-model.md Outdated Show resolved Hide resolved
src/agentscope/models/zhipu_model.py Show resolved Hide resolved
@garyzhang99 garyzhang99 requested review from DavdGao and ZiTao-Li May 1, 2024 14:54
DavdGao
DavdGao approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DavdGao DavdGao merged commit be8db4c into modelscope:main May 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavdGao DavdGao DavdGao approved these changes

@pan-x-c pan-x-c Awaiting requested review from pan-x-c

@ZiTao-Li ZiTao-Li Awaiting requested review from ZiTao-Li

Assignees

@garyzhang99 garyzhang99

Labels
documentation Improvements or additions to documentation enhancement New feature or request ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@garyzhang99 @DavdGao @ZiTao-Li