Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agent servers support running any type of agent #135

Merged
merged 78 commits into from
Apr 30, 2024
Merged

Agent servers support running any type of agent #135

merged 78 commits into from
Apr 30, 2024

Conversation

pan-x-c
Copy link
Collaborator

@pan-x-c pan-x-c commented Apr 2, 2024 •
edited
Loading

Description

Based on #94

  1. rename RpcServerSideWrapper into AgentPlatform
  2. Simplify the setup of agent platform. Only host and port are necessary. (custom_agents is required, if using agent class written by the user)
  3. AgentPlatform is completely decoupled from Agent. Multiple different types of agents can run on the same agent platform now.
  4. RpcAgentServer now starts in an async way
  5. Deprecated the launch_server parameter in to_dist method. When the host and port are not passed in, the server will be started automatically
  6. Support using to_dist=True to initialize any AgentBase subclass to convert the agent into its distributed version
  7. Support agent nesting
  8. Add a large scale simulation example
  9. Rewrite the distributed deployment tutorial

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

pan-x-c added 21 commits March 21, 2024 17:49
@pan-x-c
agent server support multiple session
8d5a475
@pan-x-c
support delete session
5e88e1f
@pan-x-c
support to clone multiple instances with different session_id
f6ec1a2
@pan-x-c
fix distribtued examples
d4b9334
@pan-x-c
reorganize distributed examples
e299788
@pan-x-c
support to init session agent instance with user provided args
aad935d
@pan-x-c
update default max_pool_size
44ceeb8
@pan-x-c
opt placeholder _get method
2842884
@pan-x-c
Merge branch 'main' into feature/pxc/session_for_rpc_agent
131051e
@pan-x-c
reuse channel stub
2170428
@pan-x-c
opt placeholder
89e9afc
@pan-x-c
update docs for rpc client
285e3ac
@pan-x-c
merge main
c659748
@pan-x-c
rename session_id to agent_id
e94d70d
@pan-x-c
rename session_id to agent_id
a9d0b11
@pan-x-c
Merge branch 'main' into feature/pxc/session_for_rpc_agent
758a276
@pan-x-c
fix agent_id
fff3e23
@pan-x-c
update test for agent_id
d2199b0
@pan-x-c
opt agent instance init
9355e24
@pan-x-c
fix format
cd81bd2
@pan-x-c
change rpc agent server into AgentPlatform and support any type of agent
d5dc287
@pan-x-c pan-x-c added enhancement New feature or request feature labels Apr 2, 2024
@pan-x-c pan-x-c self-assigned this Apr 2, 2024
DavdGao
DavdGao reviewed Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have two issues in this modification:

  1. If it's appropriate to add a new entry for distributed agent. I know directly instantiate a distributed agent object will save time, but the in this way the local mode and distributed mode are mixed.
  2. If the new entry is necessary. Please move the initialization arguments to the constructor of AgentBase class, and add kwargs to the agent classses under the library agentscope.agents.

DavdGao
DavdGao reviewed Apr 26, 2024
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz see inline comments, others lgtm

examples/distributed_simulation/main.py Outdated Show resolved Hide resolved
src/agentscope/agents/agent.py Outdated Show resolved Hide resolved
pan-x-c and others added 14 commits April 26, 2024 10:28
@pan-x-c
update docstring
67020ba
@pan-x-c
update dist doc
fd21daa
@pan-x-c
raise error when fail to pass openai safety system (modelscope#171)
7be5bc4
@qbc2016 @pan-x-c
Checking reset before user input in studio (modelscope#154)
857fc6a
@garyzhang99 @pan-x-c
Add execute_shell_command, list_directory_content, and get_current_di…
6de52ac 
…rectory service functions (modelscope#156)
@rayrayraykk @pan-x-c
fix mac ver (modelscope#174)
55bfeac
@rayrayraykk @pan-x-c
Add Compiler & Refactor workflow dag runner code (modelscope#164)
6657c3f
@rayrayraykk @pan-x-c
Make workflow compiler return code string (modelscope#178)
384c4d2
@qbc2016 @pan-x-c
Add displaying cycle dots before agent reply in AS studio (modelscope…
e3415b9 
…#179)

* add cycle dots before agent reply in AS studio

* change name of decorator, change type of glb_doing_signal_dict

* add refresh after reset

* decorator for reply

* init glb_doing_signal_dict

* remove js in reset_button.click since it does not work
@pan-x-c
[DOC] Generate .rst for each .py file and add __init__ method into do…
f0c1ef9 
…cs (modelscope#180)
@pan-x-c
update dist doc
e047a8d
@pan-x-c
fix conflict
7dffa5b
@pan-x-c
use distconf
4304fcc
@pan-x-c
update tutorial for dist
7da9427
DavdGao
DavdGao approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DavdGao DavdGao merged commit c431015 into modelscope:main Apr 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZiTao-Li ZiTao-Li ZiTao-Li left review comments

@rayrayraykk rayrayraykk rayrayraykk left review comments

@DavdGao DavdGao DavdGao approved these changes

@qbc2016 qbc2016 Awaiting requested review from qbc2016

Assignees

@pan-x-c pan-x-c

Labels
enhancement New feature or request feature ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pan-x-c @rayrayraykk @DavdGao @ZiTao-Li @qbc2016 @garyzhang99