GetModelContentType: throw exception when no UmbracoContext exists #224
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This 'fixes' issue #222 and should be able to get merged with PR #223.
Instead of throwing an
ArgumentNullException
, this method now throws anInvalidOperationException
indicating it requires anUmbracoContext
to be present.To make it all work, callers should ensure this using
IUmbracoContextFactory.EnsureUmbracoContext()
as described in #222 (comment).If you only need the property alias, the new
GetModelPropertyTypeAlias
method from PR #223 (comment) doesn't require theUmbracoContext
.