Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable sourcelink #207

Open
wants to merge 2 commits into
base: v8/dev
Choose a base branch
from
Open

Enable sourcelink #207

wants to merge 2 commits into from

Conversation

warrenbuckley
Copy link
Collaborator

A re-target PR of #197

This should add SourceLink @zpqrtbnk to the NuGet packages

Warren Buckley added 2 commits May 2, 2019 15:58
Update NuSpecs with the XML metadata for SourceLink
267c19b
Added in Microsoft.SourceLink.GitHub Nuget package - unable to build …
1ebac35 
…locally with PS1 build script seems it wants a very specific VS SDK installed even though VS17 & VS19 SDK tool is installed
@zpqrtbnk zpqrtbnk added state/backlog Backlog, To Do type/feature Feature labels Aug 29, 2019
@zpqrtbnk zpqrtbnk added this to the 4.0.0 milestone Aug 29, 2019
@zpqrtbnk
Copy link
Collaborator

zpqrtbnk commented Sep 3, 2019

Planning to merge for milestone 4.0.0 assuming source is public

@warrenbuckley
Copy link
Collaborator Author

Planning to merge for milestone 4.0.0 assuming source is public
Is V4.0 planned to be ner Open Source then @zpqrtbnk ?

@bielu
Copy link
Contributor

bielu commented Sep 30, 2020

Hi @zpqrtbnk,
that one became redundant if we merge:
#241
:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
state/backlog Backlog, To Do type/feature Feature
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@warrenbuckley @zpqrtbnk @bielu