Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/memory improvements #392

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

s2005
Copy link

@s2005 s2005 commented Dec 21, 2024

Description

Add support for configuring memory storage location via environment variable, enhancing deployment flexibility while maintaining backward compatibility.

Server Details

  • Server: memory
  • Changes to: configuration, documentation

Motivation and Context

Currently, the memory server uses a fixed storage location. This change allows users to specify custom storage locations through environment variables, making it more flexible for different deployment scenarios and improving container compatibility.

How Has This Been Tested?

Tested with Claude Desktop client using:

  • Default configuration (no environment variable)
  • Absolute path configuration
  • Relative path configuration
  • Docker configuration has been tested
    All core functionality (entity creation, relation management, observation handling) remains unchanged.

Breaking Changes

No breaking changes. Default behavior remains the same, only adding optional configuration capability.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Protocol Documentation
  • My changes follows MCP security best practices
  • I have updated the server's README accordingly
  • I have tested this with an LLM client
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have documented all environment variables and configuration options

Additional context

  • Add environment variable MEMORY_FILE_PATH to configure custom storage location
  • Support both absolute and relative paths
  • Update documentation with configuration examples
  • Bump version to 0.6.3

s2005 and others added 3 commits December 21, 2024 18:38
- Add environment variable MEMORY_FILE_PATH to configure custom storage location
- Support both absolute and relative paths
- Update documentation with configuration examples
- Bump version to 0.6.3
@s2005 s2005 marked this pull request as ready for review December 21, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant