Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct package name for sequential thinking server #186

Conversation

Hunter-Houts
Copy link

Description

This PR fixes an inconsistency in the package naming for the sequential thinking server. The root package.json was referencing @modelcontextprotocol/server-sequentialthinking while the actual package name uses hyphens @modelcontextprotocol/server-sequential-thinking. This inconsistency was causing npm install errors.

Server Details

  • Server: sequential-thinking
  • Changes to: package configuration and naming

Motivation and Context

When running npm install in the sequential thinking server directory, it fails with a 404 error because npm is looking for a non-existent package name (without hyphens). This fix ensures consistent naming across all package references, allowing proper installation and workspace configuration.

Error being fixed:

npm WARN workspaces @modelcontextprotocol/server-sequential-thinking in filter set, but no workspace folder present
npm ERR! 404 Not Found - GET https://registry.npmjs.org/@modelcontextprotocol%2fserver-sequentialthinking

How Has This Been Tested?

  • Verified npm install works correctly after the name change
  • Confirmed workspace configuration recognizes the package
  • Tested package binary name functionality

Breaking Changes

No breaking changes. This is a fix for an existing issue that prevented proper installation.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the MCP Protocol Documentation
  • My server follows MCP security best practices
  • My code follows the repository's style guidelines
  • I have added appropriate error handling

Additional context

The change ensures consistent naming convention across the monorepo:

  1. Changed in root package.json:
    - "@modelcontextprotocol/server-sequentialthinking": "*"
    + "@modelcontextprotocol/server-sequential-thinking": "*"
  2. Verified package.json in src/sequentialthinking maintains hyphenated naming:
    {
      "name": "@modelcontextprotocol/server-sequential-thinking",
      "bin": {
        "mcp-server-sequential-thinking": "dist/index.js"
      }
    }

@Hunter-Houts Hunter-Houts force-pushed the fix-sequential-thinking branch from 144b764 to 67cee2d Compare December 3, 2024 01:52
@dsp-ant
Copy link
Member

dsp-ant commented Dec 3, 2024

Sorry I missed this PR and already fixed it on main. I really appreciate the contribution. My bad for not spotting the PR before fixing it myself. I am closing this out but rest assured that I am grateful for the fix!

@dsp-ant dsp-ant closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants