Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added aws kb server #180

Merged
merged 5 commits into from
Dec 5, 2024

Conversation

Skirano
Copy link
Contributor

@Skirano Skirano commented Dec 2, 2024

Description

Addition of a new MCP server for AWS Knowledge Base retrieval, leveraging the Bedrock Agent Runtime to fetch information based on user queries.

Server Details

  • Server: aws-kb-retrieval
  • Changes to: tools (new tool added)

Motivation and Context

To enhance the capability of the MCP client by enabling it to retrieve information from AWS Knowledge Bases directly. This integration simplifies the process of sourcing relevant data for users.

How Has This Been Tested?

The server has been tested with an LLM client by integrating it into the Claude Desktop setup. Various scenarios, including different queries and Knowledge Base IDs, were tested to ensure functionality.

Breaking Changes

Users will need to update their MCP client configurations to include this new server and provide their AWS credentials.

Types of changes

  • New MCP Server
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Protocol Documentation
  • My server follows MCP security best practices
  • I have updated the server's README accordingly
  • I have tested this with an LLM client
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have documented all environment variables and configuration options

Additional context

This integration requires users to set up their AWS credentials securely. The server has been optimized for performance and security, with careful consideration given to error handling and edge cases.

This form is filled out based on the AWS Knowledge Base Retrieval server you've developed. Adjustments can be made as necessary to align with your specific implementation or any additional requirements.

jspahrsummers
jspahrsummers previously approved these changes Dec 3, 2024
Copy link
Member

@jspahrsummers jspahrsummers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you please make sure all servers are listed in the top-level README.md too?

@@ -0,0 +1,30 @@
{
"name": "@modelcontextprotocol/server-aws-kb-retrieval",
"version": "0.1.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please match the version to the rest of the servers? They're released in batch right now (although we want to change this).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

jspahrsummers
jspahrsummers previously approved these changes Dec 5, 2024
Copy link
Member

@jspahrsummers jspahrsummers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jspahrsummers jspahrsummers merged commit 9505342 into modelcontextprotocol:main Dec 5, 2024
23 checks passed
@jexp
Copy link
Contributor

jexp commented Dec 11, 2024

I thought community servers should stay outside of MCP? I'm confused.

@jspahrsummers
Copy link
Member

@Skirano works with our team directly. However, we are also considering whether to pare down the servers already committed to the repo, to ease maintenance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants