Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deserialization of URL #177

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

jackadamson
Copy link
Contributor

Description

Fixes #163 by passing around a string URL to child functions, while still using AnyUrl for doing validation.

Server Details

  • Server: fetch
  • Changes to: tools

Motivation and Context

Minor bug fix to address #163

How Has This Been Tested?

I was able to reproduce the issue locally, and after this change it works in both the npx inspector and in the Claude Desktop app.

Breaking Changes

No breaking chanes.

Types of changes

  • New MCP Server
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Protocol Documentation
  • My server follows MCP security best practices
  • I have updated the server's README accordingly
  • I have tested this with an LLM client
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have documented all environment variables and configuration options

@jackadamson jackadamson requested a review from dsp-ant December 2, 2024 13:22
@dsp-ant
Copy link
Member

dsp-ant commented Dec 2, 2024

Thank you

@dsp-ant dsp-ant merged commit 3f48a1c into main Dec 2, 2024
23 checks passed
@dsp-ant dsp-ant deleted the jadamson/fetch-url-serialize-fix branch December 2, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mcp-server-fetch on Mac throws error 'AnyUrl' object has no attribute 'decode'
2 participants