Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bump dependencies for release 0.36.0" #2740

Closed
wants to merge 1 commit into from

Conversation

adpaco-aws
Copy link
Contributor

Description of changes:

Reverts #2738 which is showing a regression in one of the perf-benchcomp tests:

benchcomp: WARNING: Benchmark 's2n-quic/quic/s2n-quic-core/random::tests::gen_range_biased_test' regressed on metric 'solver_runtime' (7.5601711 -> 12.9946927)

It was a mistake to merge it in the first place, but auto-merge doesn't care about the status non-required CI jobs. The perf-benchcomp CI has failed

I'd like to revert the changes first, and then investigate if the change in dependencies are actually contributing to this.

Testing:

  • How is this change tested?

  • Is this a refactor change?

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@adpaco-aws adpaco-aws requested a review from a team as a code owner September 6, 2023 21:25
@zhassan-aws
Copy link
Contributor

There is no need to revert. We've seen fluctuations in this benchmark previously.

@adpaco-aws adpaco-aws closed this Sep 6, 2023
@adpaco-aws
Copy link
Contributor Author

Thanks @zhassan-aws , I didn't recall seeing this regression before.

@adpaco-aws adpaco-aws deleted the revert-2738-update-dependencies-0.36.0 branch November 30, 2023 13:17
@adpaco-aws adpaco-aws restored the revert-2738-update-dependencies-0.36.0 branch November 30, 2023 13:17
@adpaco-aws adpaco-aws deleted the revert-2738-update-dependencies-0.36.0 branch November 30, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants