Fix #488 -- Align GFK and content type fields #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amureki
force-pushed
the
488/align-gfk-fields
branch
from
b25e996
to
e1557b4
Compare
Comment on lines
+702
to
+707
| setattr( | ||
| instance, | ||
| content_type_field, | ||
| contenttypes_models.ContentType.objects.get_for_model(value), | ||
| ) | ||
| setattr(instance, object_id_field, value.pk) |
There was a problem hiding this comment.
After this change, null values for a generic foreign key (where both the content_type and object_id fields are nullable) fail here. I believe this section should be skipped when value is None.
There was a problem hiding this comment.
Hm, you are right!
I have drafted #496 to address that, however it would not prevent content_type and object_id from generating random values in case they are not nullable and content_object is None.
(This was never a case before either, so I am not sure how critical it is to cover now - as it is not easy).
There was a problem hiding this comment.
Released 1.19.3 adjusting this:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Replace a hacky workaround from 0b4cfa7#diff-7aca726c4b3af089805b51a56736cde676621ea8b404f024d8e51d879677ee09R17 with proper GFK field handling.
So now, the content type and object id should be filled from the provided content object.
PR Checklist