native_layer: Add support for creating async task tracks #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dflemstr
commented
Nov 22, 2024
| @@ -66,7 +73,7 @@ impl SequenceId { | |||
| #[cfg(feature = "tokio")] | |||
| pub fn for_task(id: task::Id) -> SequenceId { | |||
| let mut h = hash::DefaultHasher::new(); | |||
| (TRACK_UUID_NS, TASK_NS, id).hash(&mut h); | |||
| (SEQUENCE_ID_NS, TASK_NS, id).hash(&mut h); | |||
There was a problem hiding this comment.
Accidental typo in a previous PR, but shouldn't have mattered too much as SequenceId and TrackUuid are already in separate namespaces.
dflemstr
force-pushed
the
dflemstr/create-async-tracks
branch
from
5225b86 to
7677a0a
Compare
dflemstr
commented
Nov 22, 2024
| target_os = "android", | ||
| target_os = "emscripten", | ||
| target_os = "fuchsia" | ||
| ))] |
There was a problem hiding this comment.
Started getting annoying deprecation warnings for these so might as well fix them while passing through
gimaker
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is valuable when having a lot of async/concurrent operations. By emitting tracks for async tasks, we can correlate spans emitted from that same task in that they preserve some parent/child semantics. To have the Perfetto UI not break completely, these tracks all have to have the same name so that they are collapsed in the UI.