Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic flatpak support #69

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add basic flatpak support #69

wants to merge 5 commits into from

Conversation

agorgl
Copy link

@agorgl agorgl commented Nov 5, 2024

Adds working flatpak manifest based on github releases

Adds working flatpak manifest based on github releases
@falkTX
Copy link
Member

falkTX commented Nov 5, 2024

A very good start, but how do we even build this?

A CI step to generate some flatpak file would be great.

@agorgl
Copy link
Author

agorgl commented Nov 5, 2024

As per the official flatpak documentation (https://docs.flatpak.org/en/latest/first-build.html), building it is as simple as:

flatpak-builder --force-clean --user --install-deps-from=flathub --repo=repo --install builddir audio.mod.mod-desktop.yaml

@agorgl
Copy link
Author

agorgl commented Nov 5, 2024

I suppose we could use this action to build it using the CI:
https://github.com/flatpak/flatpak-github-actions

@agorgl
Copy link
Author

agorgl commented Nov 5, 2024

Just added a basic github action to build the flatpak too

@agorgl agorgl changed the title Add basic flatpak manifest Add basic flatpak support Nov 5, 2024
@falkTX
Copy link
Member

falkTX commented Nov 5, 2024

the CI needs to trigger for regular pushes and PRs, not just on release

@agorgl
Copy link
Author

agorgl commented Nov 5, 2024

Currently the flatpak manifest depends upon releases, so there is no point in running the flatpak github action on regular pushes and PRs yet. After supporting build from latest sources then we can change the flatpak action to run on every push and PR.

@falkTX
Copy link
Member

falkTX commented Nov 5, 2024

sure but we need to test if it even works first, and the point is to not have it use release binaries anyhow.

@agorgl
Copy link
Author

agorgl commented Nov 5, 2024

Yeah, the whole point of this PR is to provide a basis for flatpak support, and make a flatpak build that can be published to flathub.

As a second step we can augment this even more and modify the flatpak manifest to build from sources and not from releases, and finally merge the flatpak action as part of the build workflow/process to have flatpak binaries on releases too, along with every PR/commit.

@falkTX
Copy link
Member

falkTX commented Nov 5, 2024

sure but I wish to test if the CI action works before merging, and that is not possible to do if the CI file requires a new release to be made just to test it...

it is fine to let the CI run more often than needed, but the other way around is not.

@agorgl
Copy link
Author

agorgl commented Nov 5, 2024

Changed flatpak workflow trigger event to on: workflow_dispatch to allow for manual triggers, as this is currently the best fit for this setup

@agorgl
Copy link
Author

agorgl commented Nov 5, 2024

Resulting flatpak now also exports the correct icon and desktop file

@agorgl
Copy link
Author

agorgl commented Nov 5, 2024

Added the required metainfo file that is needed for publishing in relevant hubs/stores like flathub also, the app should be ready for publishing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants