-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Freezer #1
Freezer #1
Conversation
Hey, I see two issues with your patch:
To fix 1. make sure you either add this table or use the correct name that you intend. For 2. disable the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hope now it will be ok.
Builds succeed at least! My only comment would be on the patch itself as it is very hard to read, but it's your code so you can maintain it how you like ;) |
lets get things moving again, merging this now. sorry for the very long delay, company stuff was happening and a whole lot of complications. but now slowly resuming operations and everything back again. |
Reminder for myself: need to add a way to do custom ttl from this repo. though there is now an alternative with us starting to package some hvcc based plugins, for example https://github.com/mod-audio/mod-plugin-builder/blob/master/plugins/package/sensorium-plugins/sensorium-plugins.mk we can also store the pd files directly in mod-plugin-builder together with the mk file like the one in the link above, but that complicated things for the case of custom ttl because it then needs to go into a separate repo and being kept in sync... @Battery-not-included would you prefer to keep pushing files to this repo and we help with reviewing things, or handle the git repo yourself? |
Hi, for now it is better for me to put the file in this repository. By the way I see the changes in the cloud builder for pd where the option for multiple files is added, with that it is now possible to use abstraction and midi functions, nice update thanks. |
@Battery-not-included I was going to start integrating the custom ttl, so I grabbed the latest one you have on the forums, the duox build https://drive.google.com/file/d/1iZlF7ehbDHOfX4KgUIjOYjAsy0zGGNeZ/view?usp=drive_link but that custom ttl does not match the pd file we have here. Here is the diff between the custom ttl and the one generated by dpf: --- Freezer_dsp.ttl 2024-10-11 11:32:35.609500453 +0200
+++ _Freezer_dsp.ttl 2024-10-11 11:32:35.612500560 +0200
@@ -57,22 +57,42 @@
lv2:index 3 ;
lv2:name "attack" ;
lv2:symbol "attack" ;
- lv2:default 500 ;
+ lv2:default 100 ;
lv2:minimum 0 ;
lv2:maximum 2000 ;
] ,
[
a lv2:InputPort, lv2:ControlPort ;
lv2:index 4 ;
+ lv2:name "current step" ;
+ lv2:symbol "current_step" ;
+ lv2:default 1 ;
+ lv2:minimum 1 ;
+ lv2:maximum 6 ;
+ lv2:portProperty lv2:integer ;
+ ] ,
+ [
+ a lv2:InputPort, lv2:ControlPort ;
+ lv2:index 5 ;
lv2:name "decay" ;
lv2:symbol "decay" ;
- lv2:default 500 ;
+ lv2:default 100 ;
lv2:minimum 0 ;
lv2:maximum 2000 ;
] ,
[
a lv2:InputPort, lv2:ControlPort ;
- lv2:index 5 ;
+ lv2:index 6 ;
+ lv2:name "decay x10" ;
+ lv2:symbol "decay_x10" ;
+ lv2:default 1 ;
+ lv2:minimum 1 ;
+ lv2:maximum 10 ;
+ lv2:portProperty lv2:toggled ;
+ ] ,
+ [
+ a lv2:InputPort, lv2:ControlPort ;
+ lv2:index 7 ;
lv2:name "dry" ;
lv2:symbol "dry" ;
lv2:default 1 ;
@@ -81,26 +101,63 @@
] ,
[
a lv2:InputPort, lv2:ControlPort ;
- lv2:index 6 ;
+ lv2:index 8 ;
lv2:name "freeze" ;
lv2:symbol "freeze" ;
lv2:default 0 ;
lv2:minimum 0 ;
lv2:maximum 1 ;
- lv2:portProperty lv2:toggled ;
+ lv2:portProperty lv2:toggled , mod:preferMomentaryOnByDefault ;
] ,
[
a lv2:InputPort, lv2:ControlPort ;
- lv2:index 7 ;
+ lv2:index 9 ;
+ lv2:name "layers number" ;
+ lv2:symbol "layers_number" ;
+ lv2:default 1 ;
+ lv2:minimum 1 ;
+ lv2:maximum 6 ;
+ lv2:portProperty lv2:integer ;
+ ] ,
+ [
+ a lv2:InputPort, lv2:ControlPort ;
+ lv2:index 10 ;
+ lv2:name "layers volume" ;
+ lv2:symbol "layers_volume" ;
+ lv2:default 0.8 ;
+ lv2:minimum 0 ;
+ lv2:maximum 1 ;
+ ] ,
+ [
+ a lv2:InputPort, lv2:ControlPort ;
+ lv2:index 11 ;
lv2:name "mode" ;
lv2:symbol "mode" ;
lv2:default 0 ;
lv2:minimum 0 ;
lv2:maximum 1 ;
] ,
[
a lv2:InputPort, lv2:ControlPort ;
- lv2:index 8 ;
+ lv2:index 12 ;
+ lv2:name "sample length" ;
+ lv2:symbol "sample_length" ;
+ lv2:default 1 ;
+ lv2:minimum 0.2 ;
+ lv2:maximum 1 ;
+ ] ,
+ [
+ a lv2:InputPort, lv2:ControlPort ;
+ lv2:index 13 ;
lv2:name "speed" ;
lv2:symbol "speed" ;
lv2:default 1 ;
@@ -109,7 +166,7 @@
] ,
[
a lv2:InputPort, lv2:ControlPort ;
- lv2:index 9 ;
+ lv2:index 14 ;
lv2:name "wet" ;
lv2:symbol "wet" ;
lv2:default 1 ; Since your duox custom ttl has more parameters, I imagine you have since tweaked the pd file for it. |
Yeah, I have a newer version on the forum. I will be updating the PD file there. |
it is best if we keep things centralized here, we need to have the files in here in order to do builds anyhow. |
sorry i mean here not there :) i will update pd file here. |
Does it work now? I have updated it in my Forks and I don't know if this is the right way. |
No description provided.