Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed where finalization callbacks are called #286

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

mdorier
Copy link
Contributor

@mdorier mdorier commented Aug 27, 2024

No description provided.

@mdorier mdorier requested a review from carns August 27, 2024 17:25
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.62%. Comparing base (84245fe) to head (9c2cd19).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #286   +/-   ##
=======================================
  Coverage   57.61%   57.62%           
=======================================
  Files          70       70           
  Lines       10150    10152    +2     
  Branches     1337     1337           
=======================================
+ Hits         5848     5850    +2     
  Misses       3468     3468           
  Partials      834      834           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@carns carns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@mdorier mdorier merged commit d3c7a9b into main Aug 27, 2024
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants